trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From selvaganesang <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: [Trafodion-1424] Enable CIF for ...
Date Wed, 05 Aug 2015 20:43:08 GMT
Github user selvaganesang commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/44#discussion_r36351677
  
    --- Diff: core/sql/executor/ExHbaseAccess.cpp ---
    @@ -1645,12 +1650,18 @@ Lng32 ExHbaseAccessTcb::createSQRowFromAlignedFormat(Int64 *latestRowTimestamp)
       
       if (convertExpr())
         {
    +      convertRowLen_ = hbaseAccessTdb().convertRowLen();
    +      UInt32 rowLen = convertRowLen_;
           ex_expr::exp_return_type evalRetCode =
    -	convertExpr()->eval(pentry_down->getAtp(), workAtp_, NULL, asciiRowLen);
    +	convertExpr()->eval(pentry_down->getAtp(), workAtp_, NULL, 
    +			    asciiRowLen, &rowLen);
           if (evalRetCode == ex_expr::EXPR_ERROR)
     	{
     	  return -1;
     	}
    +      if (hbaseAccessTdb().getUseCif() &&
    +      rowLen < convertRowLen_)
    +        convertRowLen_=rowLen;
    --- End diff --
    
    Will the rowLen be less than convertRowLen from the compiler. I believe convertRowLen_
might have been ujsed to pre-allocate row buffer. There could be buffer overflow. Can you
please confirm that is not the case.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message