trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From amandamoran <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: [Trafodion-1433] [Trafodion-39] ...
Date Mon, 10 Aug 2015 18:40:20 GMT
Github user amandamoran commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/50#discussion_r36668287
  
    --- Diff: install/installer/tools/ambari_setup ---
    @@ -62,6 +65,9 @@ done
     #Info for log file
     sudo mkdir -p /var/log/trafodion
     sudo chmod 777 /var/log/trafodion
    +
    +linuxInstalled=$(grep -cr SUSE /proc/version)
    --- End diff --
    
    Actually the grep -c returns a number value. So if SUSE is not installed, it will return
a 0 not an empty string. I had to go test this out to make sure if does that (as I couldn't
recall) and it does. I did change the variable name to be more clear/.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message