trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From amandamoran <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: [Trafodion-1433] [Trafodion-39] ...
Date Wed, 12 Aug 2015 19:52:44 GMT
Github user amandamoran commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/50#discussion_r36905389
  
    --- Diff: install/installer/trafodion_install ---
    @@ -696,29 +625,30 @@ reservedTrafodionPorts="net.ipv4.ip_local_reserved_ports = ${trafodion_ports}"
     
     for node in $NODE_LIST
     do
    -   redhatSystem=$(ssh $node -n '/sbin/sysctl net.ipv4.ip_local_reserved_ports | wc -l')
    +   redhatSystem=$(ssh -q -n $node '/sbin/sysctl net.ipv4.ip_local_reserved_ports | wc
-l')
        if [[ "$redhatSystem" -ge "1" ]]; then
    -      reserved_ports=$(ssh $node -n '/sbin/sysctl net.ipv4.ip_local_reserved_ports' |
awk -F'=' '{print $2;}' | sed 's/^ //')
    -      ssh $node -n 'sudo chmod 777 /etc/sysctl.conf'
    -      ssh $node -n 'sudo sed -i '/net.ipv4.ip_local_reserved_ports""\=*/d' /etc/sysctl.conf'
    +      reserved_ports=$(ssh -q -n $node '/sbin/sysctl net.ipv4.ip_local_reserved_ports'
| awk -F'=' '{print $2;}' | sed 's/^ //')
    +      ssh -q -n $node 'sudo chmod 777 /etc/sysctl.conf'
    +      ssh -q -n $node 'sudo sed -i '/net.ipv4.ip_local_reserved_ports""\=*/d' /etc/sysctl.conf'
     
        if [[ -z "${reserved_ports}" ]]; then
    -      ssh $node -n 'sudo echo "$reservedTrafodionPorts" >> /etc/sysctl.conf'
    +      ssh -q -n $node "sudo echo "$reservedTrafodionPorts" >> /etc/sysctl.conf"
        else
    -      ssh $node -n "sudo echo "$reservedTrafodionPorts","$reserved_ports" >> /etc/sysctl.conf"
    +      ssh -q -n $node "sudo echo "$reservedTrafodionPorts","$reserved_ports" >>
/etc/sysctl.conf"
        fi
    -   ssh $node -n 'sudo chmod 644 /etc/sysctl.conf'
    -   ssh $node -n 'sudo /sbin/sysctl -p'
    +   ssh -q -n $node 'sudo chmod 644 /etc/sysctl.conf'
    +   ssh -q -n $node 'sudo /sbin/sysctl -p' 2>&1 > /dev/null
        else
    -      echo "***ERROR: Unable to reserve DCS ports (${trafodion_ports})."
    +      echo "***ERROR: Unable to reserve DCS ports (37800 and 40010)."
    --- End diff --
    
    Thanks for the find!
    
    Fixed!
    
    On Wed, Aug 12, 2015 at 12:29 PM, arvind-narain <notifications@github.com>
    wrote:
    
    > In install/installer/trafodion_install
    > <https://github.com/apache/incubator-trafodion/pull/50#discussion_r36902901>
    > :
    >
    > >     else
    > > -      echo "***ERROR: Unable to reserve DCS ports (${trafodion_ports})."
    > > +      echo "***ERROR: Unable to reserve DCS ports (37800 and 40010)."
    >
    > Since the default ports changed (line 623) could you revert this change to
    > utilize the trafodion_ports var ?
    >
    > —
    > Reply to this email directly or view it on GitHub
    > <https://github.com/apache/incubator-trafodion/pull/50/files#r36902901>.
    >
    
    
    
    -- 
    Thanks,
    
    Amanda Moran



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message