trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sureshsubbiah <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: [TRAFODION-1454] Unable to detec...
Date Mon, 17 Aug 2015 21:14:25 GMT
Github user sureshsubbiah commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/59#discussion_r37237696
  
    --- Diff: core/sql/executor/ExStats.cpp ---
    @@ -10666,6 +10688,27 @@ NABoolean ExMasterStats::filterForCpuStats(short subReqType,
           }
        }
        else
    +   if (subReqType == SQLCLI_STATS_REQ_ACTIVE_QUERIES)
    +   {
    +      if (stmtState_ != Statement::PROCESS_ENDED_)
    +      {
    +         if (exeStartTime_ != -1) {
    +            if (exeEndTime_ != -1)
    +               tsToCompare = exeEndTime_;
    +            else
    +               tsToCompare = exeStartTime_;
    +            lastActivity_ = (Int32)((currTimestamp-tsToCompare) / (Int64)1000000);
    +            if (exeEndTime_ == -1)
    +               return TRUE;
    +            else
    +            if (lastActivity_ <= etTimeInSecs) {
    --- End diff --
    
    So active queries with a default of 30 means all currently active queries (regardless
of how long they have been active for) + queries that completed in last 30 seconds. Please
ignore my previous comment.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message