trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: Fixes for Jira's trafodion-19 & ...
Date Fri, 21 Aug 2015 01:30:03 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/62#discussion_r37599330
  
    --- Diff: core/sql/optimizer/RelExeUtil.cpp ---
    @@ -3733,6 +3734,23 @@ RelExpr * DDLExpr::bindNode(BindWA *bindWA)
             return NULL;
           }
     
    +      // Hive tables can only be specified as external and must be created
    +      // with the FOR clause
    +      if (qualObjName_.isHive()) 
    +      {
    +        if (createTableNode->isExternal())
    +        {
    +          externalTable = TRUE;
    +          isHbase_ = TRUE;
    --- End diff --
    
    Just checking: We set isHbase_ to TRUE for Hive tables? Is there an isHive_ member in
the class?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message