trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nonstop-qfchen <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: Fixes for Jira's trafodion-19 & ...
Date Fri, 21 Aug 2015 19:56:19 GMT
Github user nonstop-qfchen commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/62#discussion_r37671971
  
    --- Diff: core/sql/optimizer/BindRelExpr.cpp ---
    @@ -1571,6 +1569,21 @@ NATable *BindWA::getNATable(CorrName& corrName,
           ((QualifiedName&)(table->getTableName())).setIsVolatile(TRUE);
         }
           
    +  // For now, do not allow access through the Trafodion external name created for
    +  // the HIVE object unless the inDDL flag is set.  inDDL is set for drop 
    +  // table and SHOWDDL statements.  
    +  // TDB - may want to merge the Trafodion version with the HIVE version.
    +  // TDB - similar operation may be needed for external HBase tables
    +  if ((table) && (table->isExternalTable() && (! bindWA->inDDL())))
    --- End diff --
    
    Update stats utility also needs to access the external table.  Can we change the inDDL()
method name to allowExternalHBaseTable() and allowExternalHiveTable()?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message