trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robertamarton <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: Fixes for Jira's trafodion-19 & ...
Date Fri, 21 Aug 2015 21:42:04 GMT
Github user robertamarton commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/62#discussion_r37681170
  
    --- Diff: core/sql/common/ComMisc.cpp ---
    @@ -99,3 +99,17 @@ NABoolean ComIsTrafodionReservedSchemaName(
       return FALSE;
     }
     
    +// schema names of pattern "_HV ... _" and "_HB_ ... _" are reserved to store
    +// external hive and hbase tables
    +NABoolean ComIsTrafodionExternalSchemaName (
    +                                    const NAString &schName)
    +{
    +  Int32 len (schName.length());
    +  Int32 prefixLen = sizeof(HIVE_EXT_SCHEMA_PREFIX);
    --- End diff --
    
    the prefixes are the same but should probably fix this in case they change or we add something
different.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message