trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robertamarton <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: Fixes for Jira's trafodion-19 & ...
Date Fri, 21 Aug 2015 21:48:42 GMT
Github user robertamarton commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/62#discussion_r37681645
  
    --- Diff: core/sql/sqlcomp/CmpSeabaseDDLroutine.cpp ---
    @@ -348,20 +348,32 @@ void CmpSeabaseDDL::createSeabaseLibrary(
           processReturn();
           return;
         }
    +
    +  ComTdbVirtTableTableInfo * tableInfo = new(STMTHEAP) ComTdbVirtTableTableInfo[1];
    --- End diff --
    
    I just copied this from similar code in the DDL component.  If we decide to change this,
then we should change all occurances.  Something to consider.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message