trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nonstop-qfchen <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: Fixes for Jira's trafodion-19 & ...
Date Fri, 21 Aug 2015 21:57:45 GMT
Github user nonstop-qfchen commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/62#discussion_r37682254
  
    --- Diff: core/sql/sqlcomp/CmpSeabaseDDLtable.cpp ---
    @@ -1181,6 +1421,30 @@ short CmpSeabaseDDL::createSeabaseTable2(
           return -1;
         }
     
    +  // If creating an external table, go perform operation
    +  if (createTableNode->isExternal())
    +    {
    +      retcode = createSeabaseTableExternalHive(cliInterface, createTableNode, currCatName,
currSchName);
    --- End diff --
    
    if this function returns -2, should we perform a cleanup operation of the meta-data tables
here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message