trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robertamarton <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: Fixes for Jira's trafodion-19 & ...
Date Fri, 21 Aug 2015 22:00:57 GMT
Github user robertamarton commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/62#discussion_r37682498
  
    --- Diff: core/sql/optimizer/BindRelExpr.cpp ---
    @@ -1571,6 +1569,21 @@ NATable *BindWA::getNATable(CorrName& corrName,
           ((QualifiedName&)(table->getTableName())).setIsVolatile(TRUE);
         }
           
    +  // For now, do not allow access through the Trafodion external name created for
    +  // the HIVE object unless the inDDL flag is set.  inDDL is set for drop 
    +  // table and SHOWDDL statements.  
    +  // TDB - may want to merge the Trafodion version with the HIVE version.
    +  // TDB - similar operation may be needed for external HBase tables
    +  if ((table) && (table->isExternalTable() && (! bindWA->inDDL())))
    --- End diff --
    
    inDDL was added for compound create schema commands a while back and does not seem to
be used today.  I added it as a stop gate since it was available.  It does make sense to add
it as separate fields but I didn't do it because I was not sure if we were going to keep this
rule going forward.  We may want to allow all accesses through the external name. I will add
this to my list of things to do.  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message