trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robertamarton <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: Fixes for Jira's trafodion-19 & ...
Date Mon, 24 Aug 2015 21:33:55 GMT
Github user robertamarton commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/62#discussion_r37807644
  
    --- Diff: core/sql/sqlcomp/CmpSeabaseDDLtable.cpp ---
    @@ -1181,6 +1421,30 @@ short CmpSeabaseDDL::createSeabaseTable2(
           return -1;
         }
     
    +  // If creating an external table, go perform operation
    +  if (createTableNode->isExternal())
    +    {
    +      retcode = createSeabaseTableExternalHive(cliInterface, createTableNode, currCatName,
currSchName);
    --- End diff --
    
    There is definitively an issue here that was cut and pasted from create table like further
down. 
    
    First off, the createSeabaseExternalHive should only be returning 0 or -1.  0 is successful
and -1 is failure.  A -2 is only needed if the associated HBase table needs to be removed
(hence a cleanup).  Since there is no external table, a -2 should not be returned.  
    
    This particular code code should return the retcode instead of -1:
    
      if (createTableNode->isExternal())
        {
          retcode = createSeabaseTableExternalHive(cliInterface, createTableNode, currCatName,
currSchName);
          . . .
          return retcode;
        }
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message