trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nonstop-qfchen <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: fix #JIRA 1449: missing end key.
Date Thu, 27 Aug 2015 15:32:13 GMT
Github user nonstop-qfchen commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/66#discussion_r38109368
  
    --- Diff: core/sql/generator/GenPreCode.cpp ---
    @@ -170,12 +174,16 @@ static NABoolean processConstHBaseKeys(Generator * generator,
                skey->getIndexDesc()->getOrderOfKeyValues(),
                relExpr->getGroupAttr()->getCharacteristicInputs(),
                TRUE, /* forward scan */
    -           exePreds,
    +           keyPreds,
                nonKeyColumnSet,
                idesc,
                relExpr->getGroupAttr()->getCharacteristicOutputs(),
                mySearchKeys);
     
    +      // Include any remaining key predicates that have not been 
    +      // picked up (to be used as the HBase search keys).
    +      exePreds += keyPreds;
    --- End diff --
    
    Yes. Please refer to the comment of the method. It contains the
    "left-over".
    
    On Thu, Aug 27, 2015 at 10:31 AM, DaveBirdsall <notifications@github.com>
    wrote:
    
    > In core/sql/generator/GenPreCode.cpp
    > <https://github.com/apache/incubator-trafodion/pull/66#discussion_r38109234>
    > :
    >
    > >             nonKeyColumnSet,
    > >             idesc,
    > >             relExpr->getGroupAttr()->getCharacteristicOutputs(),
    > >             mySearchKeys);
    > >
    > > +      // Include any remaining key predicates that have not been
    > > +      // picked up (to be used as the HBase search keys).
    > > +      exePreds += keyPreds;
    >
    > So, is keyPreds side-effected by the HbaseSearchKey::makeHBaseSearchKeys
    > call? Then it might be different when added back.
    >
    > —
    > Reply to this email directly or view it on GitHub
    > <https://github.com/apache/incubator-trafodion/pull/66/files#r38109234>.
    >
    
    
    
    -- 
    Regards, --Qifan



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message