trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sureshsubbiah <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: fix #JIRA 1449: missing end key.
Date Thu, 27 Aug 2015 15:57:44 GMT
Github user sureshsubbiah commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/66#discussion_r38112366
  
    --- Diff: core/sql/optimizer/SimpleScanOptimizer.cpp ---
    @@ -218,25 +218,14 @@ SimpleFileScanOptimizer::isLogicalSubPartitioned() const
     SearchKey *
     SimpleFileScanOptimizer::constructSearchKey()
     {
    +  // We do not need to incude the flatten version of RANGE SPEC predicates 
    +  // to the exePreds because SearchKey is capable of handling such predicates.
    --- End diff --
    
    I remember in the MDAM document there are examples where a predicate had to be in mdam
disjunct as well as in exe pred to give correct results. This was because mdam disjunct could
only guarantee minimal set of rows were returned (in such cases) instead of something that
exactly matched the predicate. I can look for the example if it will help.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message