trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sureshsubbiah <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: fix #JIRA 1449: missing end key.
Date Thu, 27 Aug 2015 16:05:19 GMT
Github user sureshsubbiah commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/66#discussion_r38113234
  
    --- Diff: core/sql/regress/seabase/EXPECTED010 ---
    @@ -6113,6 +6114,7 @@ DESCRIPTION
       begin_keys(incl) ....... 4,b,-2147483648
       end_keys(excl) ......... 4,b,2
       new_rec_expr ........... (D assign 'upd')
    +  predicate .............. (C < 2)
    --- End diff --
    
    It looks like we have added an exe pred that would clearly be covered by the begin/end
key. I was expecting the changes I saw to have the opposite effect (i.e. miss adding necessary
exe preds), so clearly my understanding is incomplete. However this is not that desirable
also. Any ideas why this happened?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message