trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: [TRAFODION-25] First implementat...
Date Thu, 27 Aug 2015 20:50:56 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/68#discussion_r38144507
  
    --- Diff: core/sql/regress/compGeneral/TEST071 ---
    @@ -4,6 +4,26 @@
     -- Simple test case to set up a table with computed col key prefix,
     -- do simple inserts, updates, deletes, merges.
     -------------------------------------------------------------------------
    +-- @@@ START COPYRIGHT @@@
    +--
    +-- Licensed to the Apache Software Foundation (ASF) under one
    +-- or more contributor license agreements.  See the NOTICE file
    +-- distributed with this work for additional information
    +-- regarding copyright ownership.  The ASF licenses this file
    +-- to you under the Apache License, Version 2.0 (the
    +-- "License"); you may not use this file except in compliance
    +-- with the License.  You may obtain a copy of the License at
    +--
    +--   http://www.apache.org/licenses/LICENSE-2.0
    +--
    +-- Unless required by applicable law or agreed to in writing,
    +-- software distributed under the License is distributed on an
    +-- "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +-- KIND, either express or implied.  See the License for the
    +-- specific language governing permissions and limitations
    +-- under the License.
    +--
    +-- @@@ END COPYRIGHT @@@
     
    --- End diff --
    
    Note to reviewers: I spent some time trying to design a test case for these changes, but
found it difficult due to the many CQDs we introduce in the Regress environment. So I decided
to defer this to the next check-in. But while I was fiddling with test cases, I noticed this
one test lacking a copyright.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message