trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From selvaganesang <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: [TRAFODION-1453] Improvements in...
Date Thu, 27 Aug 2015 15:12:49 GMT
GitHub user selvaganesang opened a pull request:

    https://github.com/apache/incubator-trafodion/pull/67

    [TRAFODION-1453] Improvements in Hive Scan

    The null byte is now skipped over to look for the column and record delimiter while scanning
the hdfs row buffer. The null byte will be part of the column value. The behavior of null
byte in the column value is unknown. Skipping over null byte is now in sync with other tool's
behavior.
    
    Also, improved the code to scan the buffer for both record and column delimiter once.
Earlier, the buffer was scanned twice; once for the record delimiter and another for column
delimiter.
    
    No errors are returned when null byte is found.
    
    A sql error 7002 is now reported when a unsupported row format type is accessed from Trafodion.
    
    *** ERROR[7002] The input row format of the hive table is not yet supported.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/selvaganesang/incubator-trafodion trafodion-1453

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-trafodion/pull/67.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #67
    
----
commit 5d4e0a927e801d78d97e36938d6bf2261f8e9769
Author: selvaganesang <selva.govindarajan@esgyn.com>
Date:   2015-08-27T00:51:58Z

    [TRAFODION-1453] Improvements in Hive Scan
    
    The null byte is now skipped over to look for the column
    and record delimiter while scanning the hdfs row buffer.
    The null byte will be part of the column value.
    The behavior of null byte in the column value is unknown.
    Skipping over null byte is now in sync with other tool's
    behavior.
    
    Also, improved the code to scan the buffer for both record and
    column delimiter once. Earlier, the buffer was scanned twice;
    once for the record delimiter and another for column delimiter.
    
    No errors are returned when null byte is found.
    
    A sql error 7002 is now reported when a unspported row format type is accessed
    from Trafodion.
    
    *** ERROR[7002] The input row format of the hive table is not yet supported.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message