trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From arvind-narain <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: [TRAFODION-353][TRAFODION-1200][...
Date Tue, 01 Sep 2015 01:50:54 GMT
Github user arvind-narain commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/69#discussion_r38379188
  
    --- Diff: core/sql/sqlcomp/PrivMgr.cpp ---
    @@ -894,3 +918,49 @@ void PrivMgr::setFlags()
       SQL_EXEC_SetParserFlagsForExSqlComp_Internal(INTERNAL_QUERY_FROM_EXEUTIL);
     }
     
    +// ----------------------------------------------------------------------------
    +// method::log
    +//
    +// sends a message to log4cxx implementation designed by SQL
    +//
    +// Input:
    +//    filename - code file that is performing the request 
    +//    message  - the message to log
    +//    index    - index for logging that loops through a list
    +//
    +// Background
    +//   Privilege manager code sets up a message and calls this log method
    +//   This method calls SQLMXLoggingArea::logPrivMgrInfo described in 
    +//      sqlmxevents/logmxevent_traf (.h & .cpp)
    +//   logPrivMgInfo is a wrapper class around qmscommon/QRLogger (.h & .cpp)
    --- End diff --
    
    logPrivMgrInfo - minor - can be touched later.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message