trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sureshsubbiah <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: Support for features described i...
Date Tue, 08 Sep 2015 17:21:06 GMT
Github user sureshsubbiah commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/74#discussion_r38953383
  
    --- Diff: core/sql/parser/StmtDDLDrop.cpp ---
    @@ -561,7 +561,8 @@ StmtDDLDropSchema::StmtDDLDropSchema(//const SchemaName & schemaName,
       // If the schema name specified is reserved name, users cannot drop them.
       // They can only be dropped internally.
       if ((! Get_SqlParser_Flags(INTERNAL_QUERY_FROM_EXEUTIL)) &&
    -      (ComIsTrafodionReservedSchemaName(schemaQualName_.getSchemaName())))
    +      (ComIsTrafodionReservedSchemaName(schemaQualName_.getSchemaName())) &&
    +      (!ComIsTrafodionExternalSchemaName(schemaQualName_.getSchemaName())))
    --- End diff --
    
    Should this be a ! on line 565? I would have expected the condition to be similar to line
564. If I am wrong please excuse my mistake. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message