trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robertamarton <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: Support for features described i...
Date Tue, 08 Sep 2015 18:00:28 GMT
Github user robertamarton commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/74#discussion_r38958590
  
    --- Diff: core/sql/common/ComMisc.cpp ---
    @@ -99,17 +100,74 @@ NABoolean ComIsTrafodionReservedSchemaName(
       return FALSE;
     }
     
    -// schema names of pattern "_HV ... _" and "_HB_ ... _" are reserved to store
    +// schema names of pattern "_HV_ ... _" and "_HB_ ... _" are reserved to store
     // external hive and hbase tables
     NABoolean ComIsTrafodionExternalSchemaName (
                                         const NAString &schName)
     {
       Int32 len (schName.length());
    +
    +  // check for HIVE
       Int32 prefixLen = sizeof(HIVE_EXT_SCHEMA_PREFIX);
       if (len > prefixLen && 
    -      (schName(0,prefixLen-1) == HIVE_EXT_SCHEMA_PREFIX || 
    -       schName(0,prefixLen-1) == HBASE_EXT_SCHEMA_PREFIX) && 
    -      schName(len-1) == '_' )
    +     (schName(0,prefixLen-1) == HIVE_EXT_SCHEMA_PREFIX && 
    +      schName(len-1) == '_' ))
         return TRUE;
    +
    +  // check for HBASE
    +  prefixLen = sizeof(HBASE_EXT_SCHEMA_PREFIX);
    +  if (len > prefixLen && 
    +     (schName(0,prefixLen-1) == HBASE_EXT_SCHEMA_PREFIX && 
    +      schName(len-1) == '_' ))
    +    return TRUE;
    +
       return FALSE;
     }
    +
    +// ----------------------------------------------------------------------------
    +// function: ComConvertNativeNameToTrafName
    +//
    +// this fuction converts the native HIVE or HBASE object name into its
    --- End diff --
    
    Yep, will fix on my next delivery.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message