trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robertamarton <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: Support for features described i...
Date Tue, 08 Sep 2015 18:23:08 GMT
Github user robertamarton commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/74#discussion_r38961379
  
    --- Diff: core/sql/optimizer/RelExeUtil.cpp ---
    @@ -3814,23 +3814,21 @@ RelExpr * DDLExpr::bindNode(BindWA *bindWA)
     
           qualObjName_ = dropTableNode->getTableNameAsQualifiedName();
     
    -      // Hive tables can only be specified as external and must be created
    -      // with the FOR clause
    -      if (qualObjName_.isHive())
    -      {
    -        if (dropTableNode->isExternal())
    +      // Drops of Hive and HBase external tables are allowed 
    +      if (qualObjName_.isHive() || (qualObjName_.isHbase()))
             {
    -          isHbase_ = TRUE;
    -          externalTable = TRUE;
    -        }
    -        else
    -        {
    -          *CmpCommon::diags() << DgSqlCode(-4222) << DgString0("DDL");
    -          bindWA->setErrStatus();
    -          return NULL;
    +          if (dropTableNode->isExternal())
    +            {
    +              isHbase_ = TRUE;
    --- End diff --
    
    isExternal is set when the "external" keyword is used in the drop table syntax.  It is
set for both hbase and hive tables.  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message