trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: [[Trafodion 1133]] [[Trafodion 1...
Date Wed, 09 Sep 2015 19:18:44 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/76#discussion_r39084442
  
    --- Diff: install/installer/traf_config_setup ---
    @@ -550,10 +562,10 @@ else
        exit -1
     fi
     
    -hadoopVersion=$(curl -su $username:$password http://$URL/api/v1/clusters | grep version
| grep -c CDH)
    +hadoopVersion=$(curl -su admin:admin http://$URL/api/v1/clusters | grep version | grep
-c CDH)
    --- End diff --
    
    Did you mean to hard-code admin:admin here (and below)? Seems there was a recent change
to move away from this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message