trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: [[Trafodion 1133]] [[Trafodion 1...
Date Wed, 09 Sep 2015 19:27:15 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/76#discussion_r39085350
  
    --- Diff: install/installer/traf_package_setup ---
    @@ -0,0 +1,224 @@
    +#!/bin/bash
    +
    +# @@@ START COPYRIGHT @@@
    +#
    +# Licensed to the Apache Software Foundation (ASF) under one
    +# or more contributor license agreements.  See the NOTICE file
    +# distributed with this work for additional information
    +# regarding copyright ownership.  The ASF licenses this file
    +# to you under the Apache License, Version 2.0 (the
    +# "License"); you may not use this file except in compliance
    +# with the License.  You may obtain a copy of the License at
    +#
    +#   http://www.apache.org/licenses/LICENSE-2.0
    +#
    +# Unless required by applicable law or agreed to in writing,
    +# software distributed under the License is distributed on an
    +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +# KIND, either express or implied.  See the License for the
    +# specific language governing permissions and limitations
    +# under the License.
    +#
    +# @@@ END COPYRIGHT @@@
    +
    +#  Setup Trafodion environment on a Cluster System
    +
    +#==============================================
    +
    +timestamp=$(date +%F-%H-%M-%S)
    +source /etc/trafodion/trafodion_config
    +
    +cd $LOCAL_WORKDIR
    +
    +echo "***Log File: traf_package_setup script***" >> $INSTALL_LOG
    +echo >> $INSTALL_LOG
    +echo "Username: $TRAF_USER" >> $INSTALL_LOG
    +echo "Nodes: $NODE_LIST" >> $INSTALL_LOG
    +echo "Home directory: $HOME_DIR" >> $INSTALL_LOG
    +echo >> $INSTALL_LOG
    +
    +echo "***INFO: Starting Trafodion Package Setup ($timestamp)"
    +#========================================
    +#Setting up pdsh variables
    +if [ $node_count -eq 1 ]; then
    +    TRAF_PDSH=""
    +    TRAF_PDCP=""
    +else
    +    # use the -S option to cause pdsh to return largest of
    +    # the remote command return values so we can tell if one
    +    # or more of the remote commands failed
    +    TRAF_PDSH="pdsh -R exec $MY_NODES ssh -q -n %h"
    --- End diff --
    
    The comment says, "use the -S option" but the commands don't seem to use it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message