trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sureshsubbiah <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: [TRAFODION-9] Non-blocking hbase...
Date Thu, 10 Sep 2015 15:18:01 GMT
Github user sureshsubbiah commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/77#discussion_r39172222
  
    --- Diff: core/sql/generator/GenRelUpdate.cpp ---
    @@ -2652,7 +2656,8 @@ short HbaseInsert::codeGen(Generator *generator)
       queue_index downqueuelength = (queue_index)getDefault(GEN_DP2I_SIZE_DOWN);
       Int32 numBuffers = getDefault(GEN_DP2I_NUM_BUFFERS);
     
    -  if (getInsertType() == Insert::VSBB_INSERT_USER)
    +  if (getInsertType() == Insert::VSBB_INSERT_USER &&
    +              generator->oltOptInfo()->multipleRowsReturned())
         downqueuelength = 400;
    --- End diff --
    
    If at some future point we could change this 400 to a cqd setting or a cardinality based
setting or even a constant that will read better. No change is needed now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message