trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sureshsubbiah <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: [TRAFODION-1456] Merge statement...
Date Thu, 17 Sep 2015 05:52:52 GMT
Github user sureshsubbiah commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/83#discussion_r39713217
  
    --- Diff: core/sql/executor/ExHbaseIUD.cpp ---
    @@ -472,7 +472,15 @@ ExWorkProcRetcode ExHbaseAccessInsertSQTcb::work()
     	  {
     	    rc = applyPred(scanExpr());
     	    if (rc == 1) // expr is true or no expr
    -	      step_ = CREATE_MUTATIONS;
    +	      {
    +		 rc = evalInsDelPreCondExpr();
    --- End diff --
    
    I thought of the preConditionExpr as something similar to the scanExpr. Agree that it
is on upqueue though. Do not see any benefit from changing except if we are thinking that
some steps are avoided? I can try it out, but would rather do that in a separate checkin if
we want to go that route.
    
    About VsbbUpsert, right now the preCondition expression is evaluated only for unique index
for which we need CheckAndPut. I am assuming this is always in the SQInsertTcb. Merge on native
HBase tables is also not supported yet.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message