trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <>
Subject [GitHub] incubator-trafodion pull request: [TRAFODION-28] Copyright header ...
Date Fri, 18 Sep 2015 17:19:40 GMT
Github user DaveBirdsall commented on a diff in the pull request:
    --- Diff: core/conn/unixodbc/odbc/odbcclient/unixcli/TCPIPV4/TCPIPV4.RC ---
    @@ -45,11 +45,11 @@ BEGIN
             BLOCK "000004b0"
                 VALUE "Comments", "T7968G10_01NOV2004_ABC_IPV4_1220\0"
    -            VALUE "CompanyName", "Hewlett-Packard Company\0"
    +            VALUE "CompanyName", "Esgyn Corporation\0"
                 VALUE "FileDescription", "NonStop´┐Ż ODBC/MX TCPIPV4 DLL\0"
    --- End diff --
    I'm wondering what the significance of "CompanyName" is. Perhaps we should put Apache
Software Foundation here? Also, I'm wondering if we should take out "NonStop ODBC/MX" and
replace it with something like "Apache Trafodion ODBC"?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message