trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: [TRAFODION-1492] Allow specifica...
Date Sun, 20 Sep 2015 20:47:50 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/88#discussion_r39934328
  
    --- Diff: core/sql/udrserv/udrserv.cpp ---
    @@ -170,24 +170,28 @@ static Int32 invokeUdrMethod(const char *method,
     // LCOV_EXCL_START
     // Dead Code
     // These methods are not used, and the interface has not been tested for a long time.
    -// Andy is of the opinion that we might want to retire them
    +// We might want to retire them
     static Int32 processCommandsFromFile(const char *filename, UdrGlobals &glob);
     static Int32 processSingleCommandFromFile(FILE *f, UdrGlobals &glob);
     // LCOV_EXCL_STOP
     
    +// Changed the default to 512 to limit java heap size used by SQL processes.
    +// Keep this define in sync with executor/JavaObjectInterface.cpp
    +#define DEFAULT_JVM_MAX_HEAP_SIZE 512
    --- End diff --
    
    Not a big deal, but would it be possible to move the define to a shared header file to
avoid the need to manually sync?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message