trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sureshsubbiah <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: [TRAFODION-1492] Allow specifica...
Date Mon, 21 Sep 2015 15:11:17 GMT
Github user sureshsubbiah commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/88#discussion_r39982124
  
    --- Diff: core/sql/udrserv/UdrCfgParser.cpp ---
    @@ -44,22 +44,15 @@ NABoolean UdrCfgParser::cfgFileIsOpen(NAString &errorText)
     
        NABoolean envFound = FALSE;
     
    -   if(cfgFileName = getenv("MXUDRCFG"))
    +   if(cfgFileName = getenv("TRAFUDRCFG"))
        {
           envFound = TRUE;
    -      UDR_DEBUG1("UdrCfgParser(): MXUDRCFG cfgFileName is %s", cfgFileName);
    +      UDR_DEBUG1("UdrCfgParser(): TRAFUDRCFG cfgFileName is %s", cfgFileName);
        }
        else
        {
    -     NAString s("c:/tdm_sql/udr/mxudrcfg");
    -     char installdir[1024];
    -     Lng32 resultlength = 0;
    -     Int32 res = ComRtGetInstallDir(installdir, 1024, &resultlength);
    -     if (res == 0)
    -     {
    -       s = installdir;
    -       s += "/mxudrcfg";
    -     }
    +     NAString s(getenv("MY_SQROOT"));
    --- End diff --
    
    We are using Facebook's string implementation, which is defined at https://github.com/facebook/folly/blob/master/folly/FBString.h
    
    I think it will be an empty string. I could not make that determination from FB source
code. Will try it on code with a debugger.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message