trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nonstop-qfchen <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: Jira1443 final committed
Date Mon, 21 Sep 2015 16:03:52 GMT
Github user nonstop-qfchen commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/87#discussion_r39989059
  
    --- Diff: core/sqf/sql/scripts/install_hadoop_regr_test_env ---
    @@ -214,6 +213,20 @@ fi
     
       cd $MY_TPCDS_DATA_DIR
     
    +  which iconv >>${MY_LOG_FILE} 2>&1
    +  if (( $? != 0 ))
    +  then
    +    echo "iconv utility not available. The data will be in ISO-8859-1 format."
    +  else
    +    echo "Converting the data into UTF-8 format ..."
    +    for t in date_dim time_dim item customer customer_demographics household_demographics
customer_address store promotion store_sales
    +      do
    +        iconv -f ISO-8859-1 -t UTF-8 -o ${t}.utf8.dat ${t}.dat >>${MY_LOG_FILE}
2>&1
    +        mv ${t}.utf8.dat ${t}.dat
    --- End diff --
    
    The data set is generated from dsdgen step above with the last command
    being " ./dsdgen -force $FORCE -dir $MY_TPCDS_DATA_DIR -scale $SCALE -table
    promotion   >>${MY_LOG_FILE} 2>&1".
    
    So if we rerun the command again, the input to iconv will be the same as in
    the previous run.
    
    On Mon, Sep 21, 2015 at 10:53 AM, DaveBirdsall <notifications@github.com>
    wrote:
    
    > In core/sqf/sql/scripts/install_hadoop_regr_test_env
    > <https://github.com/apache/incubator-trafodion/pull/87#discussion_r39987723>
    > :
    >
    > > @@ -214,6 +213,20 @@ fi
    > >
    > >    cd $MY_TPCDS_DATA_DIR
    > >
    > > +  which iconv >>${MY_LOG_FILE} 2>&1
    > > +  if (( $? != 0 ))
    > > +  then
    > > +    echo "iconv utility not available. The data will be in ISO-8859-1 format."
    > > +  else
    > > +    echo "Converting the data into UTF-8 format ..."
    > > +    for t in date_dim time_dim item customer customer_demographics household_demographics
customer_address store promotion store_sales
    > > +      do
    > > +        iconv -f ISO-8859-1 -t UTF-8 -o ${t}.utf8.dat ${t}.dat >>${MY_LOG_FILE}
2>&1
    > > +        mv ${t}.utf8.dat ${t}.dat
    >
    > This is not idempotent. (If we do it a second time we'll get invalid
    > data.) If this script is interrupted and restarted from the beginning, do
    > we get fresh copies of all the data?
    >
    > —
    > Reply to this email directly or view it on GitHub
    > <https://github.com/apache/incubator-trafodion/pull/87/files#r39987723>.
    >
    
    
    
    -- 
    Regards, --Qifan



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message