trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: Jira1443 final committed
Date Mon, 21 Sep 2015 16:05:25 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/87#discussion_r39989234
  
    --- Diff: core/sql/ustat/hs_globals.cpp ---
    @@ -2887,6 +2890,22 @@ Lng32 HSGlobalsClass::Initialize()
             HSHandleError(retcode);
             TM->Commit(); // Must commit this transaction (even if schema didn't get created).
           }
    +                                              /*=====================================*/
    +                                              /*   CREATE HBASE STATS SCHEMA        
*/
    +                                              /*   typically as trafodion.hbasestats
*/
    +                                              /*=====================================*/
    +    if (isNativeHbaseCat(objDef->getCatName()))
    +      {
    +        HSTranMan *TM = HSTranMan::Instance(); // Must have transaction around this.
    +        TM->Begin("Create schema for native hbase stats.");
    --- End diff --
    
    Is it known that there is no user transaction active in this code path?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message