trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sandhyasun <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: Resolving the following JIRAs re...
Date Tue, 10 Nov 2015 21:27:49 GMT
Github user sandhyasun commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/165#discussion_r44467603
  
    --- Diff: core/sql/optimizer/BindRelExpr.cpp ---
    @@ -7469,7 +7469,14 @@ RelExpr *Scan::bindNode(BindWA *bindWA)
          bindWA->setErrStatus();
          return NULL;
       }
    -
    +  if (naTable->hasLobColumn() && isSampleScan())
    --- End diff --
    
    Update statistics right now returns an error when a table has lob columns. Will open a
JIRA for that. But your question on this also showed that this if check is a bit too restrictive.
Will submit a change to move the check from binder phase to the generator phase where it's
easier to detect sample columns alone. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message