trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: Resolving the following JIRAs re...
Date Tue, 10 Nov 2015 22:12:16 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/165#discussion_r44473336
  
    --- Diff: core/sql/exp/ExpLOBaccess.cpp ---
    @@ -1693,7 +1693,9 @@ Ex_Lob_Error ExLob::readDataToLocalFile(char *fileName,  Int64 offset,
Int64 siz
         // open the targte file for writing 
         int filePerms = S_IRUSR | S_IWUSR | S_IRGRP | S_IWGRP | S_IROTH | S_IWOTH;
         int openFlags = O_RDWR ; // O_DIRECT needs mem alignment
    -    if ((LobTgtFileFlags)fileflags == Lob_Append_Or_Error )
    +    if (((LobTgtFileFlags)fileflags == Lob_Append_Or_Error ) ||
    --- End diff --
    
    Declaring fileflags to be of type LobTgtFileFlags would eliminate the need for all this
casting. And would be safer. (Not a show-stopper though.)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message