trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mashengchen <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: [TRAFODION-1530]deprecated put.g...
Date Thu, 12 Nov 2015 03:27:13 GMT
Github user mashengchen commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/166#discussion_r44618328
  
    --- Diff: core/sqf/src/seatrans/hbase-trx/src/main/java/org/apache/hadoop/hbase/regionserver/transactional/SingleVersionDeleteNotSupported.java
---
    @@ -53,13 +54,15 @@ public SingleVersionDeleteNotSupported() {
          * mechansim will currently treat DeleteColumn the same as Delete which could cause
confusion.
          */
         public static void validateDelete(final Delete delete) throws SingleVersionDeleteNotSupported
{
    -        Collection<List<KeyValue>> values = delete.getFamilyMap().values();
    -        for (List<KeyValue> value : values) {
    -            for (KeyValue kv : value) {
    -                if (Type.Delete.getCode() == kv.getType()) {
    +        Collection<List<Cell>> values = delete.getFamilyCellMap().values();
    +        for (List<Cell> value : values) {
    +            for (Cell cell : value) {
    +                KeyValue kv = new KeyValue(cell);
    --- End diff --
    
    got it


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message