trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From selvaganesang <>
Subject [GitHub] incubator-trafodion pull request: [TRAFODION-1628] Implement T2 Dr...
Date Mon, 16 Nov 2015 18:41:24 GMT
Github user selvaganesang commented on a diff in the pull request:
    --- Diff: core/conn/jdbc_type2/native/CSrvrStmt.cpp ---
    @@ -180,12 +241,88 @@ SQLRETURN SRVR_STMT_HDL::Prepare(const SQLValue_def *inSqlString,
short inStmtTy
         strncpy((char *)sqlString.dataValue._buffer, (const char *)inSqlString->dataValue._buffer,
         sqlString.dataValue._buffer[inSqlString->dataValue._length] = '\0';
    +    sqlStringLen = inSqlString->dataValue._length;
    +    MEMORY_ALLOC_ARRAY(sqlStringText, char, sqlStringLen+1);
    +    strncpy((char *)sqlStringText, (const char *)inSqlString->dataValue._buffer, sqlStringLen);
    +    sqlStringText[inSqlString->dataValue._length] = '\0';
         stmtType = inStmtType;
         holdability = inHoldability;
    +SQLRETURN SRVR_STMT_HDL::Execute(const char *inCursorName, IDL_long inInputRowCnt, IDL_short
    +        const SQLValueList_def *inValueList, 
    +        short inSqlAsyncEnable, Int32 inQueryTimeout)
    --- End diff --
    The method signature of this method and the one below looks same. If so, it is not clear
how the compiler decides to resolve this method.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message