trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sandhyasun <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: Fix for the executor/TEST106 fai...
Date Mon, 16 Nov 2015 22:10:06 GMT
Github user sandhyasun commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/175#discussion_r44991733
  
    --- Diff: core/sql/generator/GenPreCode.cpp ---
    @@ -4934,8 +4934,9 @@ RelExpr * HbaseDelete::preCodeGen(Generator * generator,
       else
       if (isUnique)
         {
    -      // do not cancel unique queries.
    -      generator->setMayNotCancel(TRUE);
    +      if (!generator->oltOptInfo()->multipleRowsReturned())
    +	// do not cancel unique queries.
    +	generator->setMayNotCancel(TRUE);
    --- End diff --
    
    Done updating the comment. Also added a similar check to HbaseUpdate . Hbase Access already
had the check in place and added just a comment. I did not find any other place that needed
this check. 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message