trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From selvaganesang <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: [TRAFODION-1628] Implement T2 Dr...
Date Tue, 17 Nov 2015 15:47:50 GMT
Github user selvaganesang commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/177#discussion_r45075811
  
    --- Diff: core/conn/jdbc_type2/native/CSrvrStmt.cpp ---
    @@ -180,12 +241,88 @@ SQLRETURN SRVR_STMT_HDL::Prepare(const SQLValue_def *inSqlString,
short inStmtTy
     
         strncpy((char *)sqlString.dataValue._buffer, (const char *)inSqlString->dataValue._buffer,
inSqlString->dataValue._length);
         sqlString.dataValue._buffer[inSqlString->dataValue._length] = '\0';
    +
    +    sqlStringLen = inSqlString->dataValue._length;
    +    MEMORY_ALLOC_ARRAY(sqlStringText, char, sqlStringLen+1);
    +    strncpy((char *)sqlStringText, (const char *)inSqlString->dataValue._buffer, sqlStringLen);
    +    sqlStringText[inSqlString->dataValue._length] = '\0';
    +
         stmtType = inStmtType;
         holdability = inHoldability;
     
         CLI_DEBUG_RETURN_SQL(PREPARE(this));
     }
     
    +SQLRETURN SRVR_STMT_HDL::Execute(const char *inCursorName, IDL_long inInputRowCnt, IDL_short
inSqlStmtType, 
    +        const SQLValueList_def *inValueList, 
    +        short inSqlAsyncEnable, Int32 inQueryTimeout)
    +{
    --- End diff --
    
    Thanks. It is my bad. I forgot to expand the hidden lines.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message