trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sureshsubbiah <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: [TRAFODION-1423] indexes are now...
Date Tue, 17 Nov 2015 16:46:07 GMT
Github user sureshsubbiah commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/178#discussion_r45084467
  
    --- Diff: core/sql/generator/GenExpGenerator.cpp ---
    @@ -2892,7 +2892,8 @@ short ExpGenerator::generateKeyEncodeExpr(const IndexDesc * indexDesc,
           if (handleSerialization)
     	{
     	  NAColumn * nac = indexDesc->getNAFileSet()->getIndexKeyColumns()[i];
    -	  if (CmpSeabaseDDL::isEncodingNeededForSerialization(nac))
    +          NABoolean isAlignedRowFormat = indexDesc->getNAFileSet()->isSqlmxAlignedRowFormat();
    +	  if ((!isAlignedRowFormat) && CmpSeabaseDDL::isEncodingNeededForSerialization(nac))
    --- End diff --
    
    Since the NAColumn object has a data member describing its serialization state, why do
we ned the additional check of !isAlignedFormat here?
    
    For example t1.b is serialized bit the correspond column in the index t1_ix1.b is part
of an aligned row and therefor not serailized. I would have expected CmpSeabaseDDL::isEncodingNeededForSerialization(nac)
to return FALSE for t1_ix1.b since you havetaken care to set up two different NAColumn objects
for the table and index.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message