trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From selvaganesang <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: TRAFODION-1635. Changes to a few...
Date Wed, 18 Nov 2015 18:55:49 GMT
Github user selvaganesang commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/181#discussion_r45242666
  
    --- Diff: core/sqf/sql/scripts/lobstart ---
    @@ -30,8 +30,8 @@ let totalNodes=`grep 'Up' $tmp_node_status | wc -l`
     while [ ${count} -lt $totalNodes ]
     do
     sqshell -a > /dev/null << eof
    -set {process \zlobsrv${count} } PERSIST_RETRIES=10,60
    -set {process \zlobsrv${count} } PERSIST_ZONES=0,1
    +set {process \$zlobsrv${count} } PERSIST_RETRIES=10,60
    +set {process \$zlobsrv${count} } PERSIST_ZONES=${count}
     exec {name \$zlobsrv${count}, nowait, nid ${count}, out stdout_\$ZLOBSRV${count} } mxlobsrvr
    --- End diff --
    
    It looks like this lobstart script attempts to configure and start the lob servers in
the nodes which are Up, while the change in sqgen configures it on all nodes. Let's say if
we bring the cluster with one node down, the lobstart won't even configure the lob process
on that node. When the node is reintegrated, will the lob processes come up. Also, my recommendation
would be to configure the lobprocess in sqgen and let sqgen generate the lobstart script.
That way, when the cluster is started with node down, the lob process would also be configured
for the downed node and flagged as not available. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message