trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <>
Subject [GitHub] incubator-trafodion pull request: [TRAFODION-1100] Creator of view...
Date Thu, 19 Nov 2015 17:28:56 GMT
Github user DaveBirdsall commented on a diff in the pull request:
    --- Diff: core/sql/sqlcomp/CmpSeabaseDDLview.cpp ---
    @@ -1404,17 +1456,22 @@ short CmpSeabaseDDL::dropMetadataViews(ExeCliInterface * cliInterface)
     static bool checkAccessPrivileges(
        const ParTableUsageList & vtul,
        const ParViewColTableColsUsageList & vctcul,
    +   NABoolean viewCreator,
        PrivMgrBitmap & privilegesBitmap,
        PrivMgrBitmap & grantableBitmap)
    +  BindWA bindWA(ActiveSchemaDB(),CmpCommon::context(),FALSE/*inDDL*/);
    --- End diff --
    Thanks for changing the indentation. This is much easier to read. (At least for me.)

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message