trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sandhyasun <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: TRAFODION-1635. Changes to a few...
Date Thu, 19 Nov 2015 23:08:04 GMT
Github user sandhyasun commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/181#discussion_r45414941
  
    --- Diff: core/sqf/sql/scripts/lobstart ---
    @@ -30,8 +30,8 @@ let totalNodes=`grep 'Up' $tmp_node_status | wc -l`
     while [ ${count} -lt $totalNodes ]
     do
     sqshell -a > /dev/null << eof
    -set {process \zlobsrv${count} } PERSIST_RETRIES=10,60
    -set {process \zlobsrv${count} } PERSIST_ZONES=0,1
    +set {process \$zlobsrv${count} } PERSIST_RETRIES=10,60
    +set {process \$zlobsrv${count} } PERSIST_ZONES=${count}
     exec {name \$zlobsrv${count}, nowait, nid ${count}, out stdout_\$ZLOBSRV${count} } mxlobsrvr
    --- End diff --
    
    Yes the lob processes will come up when a down node is reintegrated thanks to the change
made in gensq.pl. Stylistically it could be better to have the lobstart and the lob config
db scripts together. But functionally this setup works just fine. So  would prefer not to
make further changes to rework this at this point. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message