trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: [TRAFODION-1634] Update stats on...
Date Mon, 23 Nov 2015 20:08:18 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/184#discussion_r45653714
  
    --- Diff: core/sql/ustat/hs_globals.cpp ---
    @@ -3857,7 +3759,8 @@ Lng32 HSSample::make(NABoolean rowCountIsEstimate, // input
         // need to use a vanilla INSERT statement. Otherwise, we can use SIDETREE
         // INSERTS for better performance. A current bug in the HBase interface
         // requires the use of Upsert.
    -    if (hs_globals->isHbaseTable)
    +    // For Hive tables the sample table used is a Trafodion table
    +    if (hs_globals->isHbaseTable || hs_globals->isHiveTable)
    --- End diff --
    
    I gather that fixing the Hive stats performance problem is a one-line fix (just this line)
and everything else in this change set pertains to removing obsolete DP2 sampling code?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message