trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: Support for extracting lob to bu...
Date Tue, 05 Jan 2016 23:37:46 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/248#discussion_r48911867
  
    --- Diff: core/sql/comexe/ComTdbExeUtil.cpp ---
    @@ -2231,28 +2233,32 @@ ComTdbExeUtilLobExtract::ComTdbExeUtilLobExtract
         handle_(handle),
         handleLen_(handleLen),
         toType_((short)toType),
    +    bufAddr_(bufAddr),
    +    extractSizeIOAddr_(extractSizeAddr),
         lobStorageType_(lobStorageType),
         stringParam1_(stringParam1),
         stringParam2_(stringParam2),
         stringParam3_(stringParam3),
         lobHdfsServer_(lobHdfsServer),
         lobHdfsPort_(lobHdfsPort),
    -    rowSize_(0),
    -    bufSize_(0),
    +    totalBufSize_(0),
         flags_(0)
     {
       setNodeType(ComTdb::ex_LOB_EXTRACT);
       if ((toType_ == ExtractToType::TO_BUFFER_) || (toType_ == ExtractToType::TO_STRING_))
         {
    -      // intparam1 contains the rowsize passed in via syntax
    +      /*// intparam1 contains the rowsize passed in via syntax
           // intparam2 constains the total buf size user has allocated
           rowSize_ = intParam1;
    -      bufSize_ = intParam2;
    +      bufSize_ = intParam2; */
    --- End diff --
    
    Should we just delete this block of code?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message