trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From selvaganesang <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: [TRAFODION-1727]Fixes for Databa...
Date Thu, 07 Jan 2016 01:55:30 GMT
Github user selvaganesang commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/244#discussion_r49034626
  
    --- Diff: core/conn/jdbc_type2/native/SrvrCommon.cpp ---
    @@ -1634,6 +1634,92 @@ short do_ExecSMD(
                             tableParam[0], inputParam[0], inputParam[1],
                             inputParam[2], inputParam[3]);
                         break;
    +                case SQL_API_SQLPROCEDURES:
    +                    if ((!checkIfWildCard(catalogNm, catalogNmNoEsc) || !checkIfWildCard(schemaNm,
schemaNmNoEsc) || !checkIfWildCard(
    +tableNm, tableNmNoEsc)) && !metadataId)
    +                    {
    +                        executeException->exception_nr = odbc_SQLSvc_GetSQLCatalogs_ParamError_exn_;
    +                        executeException->u.ParamError.ParamDesc = SQLSVC_EXCEPTION_WILDCARD_NOT_SUPPORTED;
    +                        FUNCTION_RETURN_NUMERIC(EXECUTE_EXCEPTION,("EXECUTE_EXCEPTION"));
    +                    }
    +
    +                    if (strcmp(catalogNm,"") == 0)
    +                        strcpy(tableName1,SEABASE_MD_CATALOG);
    --- End diff --
    
    Should this be changed to the default catalog in the connection when the catalogNm is
NULL?  Default to SEABASE instead of SEABASE_MD_CATALOG when it is not set.  Ditto for all
other APIs.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message