trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sandhyasun <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: [TRAFODION-1742] Failure of cert...
Date Thu, 07 Jan 2016 20:17:05 GMT
Github user sandhyasun commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/252#discussion_r49120536
  
    --- Diff: core/sql/executor/hiveHook.cpp ---
    @@ -319,7 +319,7 @@ struct hive_sd_desc* populateSD(HiveMetaData *md, Int32 mainSdID,
       
       // TODO : loop over SDs
       if (findAToken(md, tblStr, pos, "sd:StorageDescriptor(", 
    -                 "getTableDesc::sd:StorageDescriptor(###"))
    +                 "getTableDesc::sd:StorageDescriptor(###"),FALSE)
    --- End diff --
    
    Is the idea to suppress the error and see if the hive operation succeeds ? All the other
calls above this seem to default to TRUE?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message