trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From arvind-narain <>
Subject [GitHub] incubator-trafodion pull request: [TRAFODION-1680] Dcs needs to pr...
Date Fri, 08 Jan 2016 00:36:34 GMT
Github user arvind-narain commented on a diff in the pull request:
    --- Diff: dcs/bin/scripts/ ---
    @@ -354,7 +354,7 @@ dcsEcho "gv_float_external_ip :" $gv_float_external_ip
     dcsEcho "gv_float_internal_ip :" $gv_float_internal_ip
     #Check if AWS_CLOUD environment variable defined
    -if [[ -z $AWS_CLOUD ]]; then
    +if [[ $AWS_CLOUD == "false" ]]; then
    --- End diff --
    wasn't the earlier check ok ? Does AWS_CLOUD get set to false also or just true/empty

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message