trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: [TRaFODION-1699] Updated web sit...
Date Mon, 01 Feb 2016 17:17:07 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/294#discussion_r51448321
  
    --- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_utilities.adoc ---
    @@ -64,7 +64,7 @@ The Trafodion bulk load process takes place in two phases:
     * _Preparation phase_: In this phase, Trafodion reads the data from
     the source files in Hive or HDFS, partitions the data based on the
     target table's partitioning scheme, sorts the data, and then generates
    -KeyValue pairs that will populate the HFiles. Trafodion also encodes the
    +Key-value pairs that will populate the HFiles. Trafodion also encodes the
    --- End diff --
    
    I suspect the old text is referring to a Java class "KeyValue" (but then "KeyValue pairs"
would not be correct, "KeyValue objects" would be better). I think it is OK to change this
to "key-value" (referring to a concept rather than a Java class), but in that case it shouldn't
be capitalized.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message