trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <>
Subject [GitHub] incubator-trafodion pull request: Fixes to JIRAs 1793,1807,1808. D...
Date Fri, 05 Feb 2016 19:53:14 GMT
Github user DaveBirdsall commented on a diff in the pull request:
    --- Diff: core/sql/common/DateTimeType.cpp ---
    @@ -171,6 +172,8 @@ NABoolean DatetimeType::isEncodingNeeded() const
     NABoolean DatetimeType::operator==(const NAType& other) const
    +  DatetimeType &otherDT = (DatetimeType&)other;
    --- End diff --
    Not sure why this variable is defined. We don't use it anywhere. Doesn't hurt anything

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message