trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: Fix for REST Server pstack api
Date Mon, 08 Feb 2016 23:16:04 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/311#discussion_r52243757
  
    --- Diff: core/rest/src/main/java/org/trafodion/rest/ServerResource.java ---
    @@ -256,11 +246,13 @@ private JSONArray pstack(String program) throws IOException {
     	            String line = scanner.nextLine();
     	            if(line.contains("pstack-ing")) {
     	                continue;
    -	            } else if (line.contains("pstack")) {
    -	                if(pstack == true) {
    +				} else if (line.contains("pstack") || line.startsWith("--")) {
    +					if (pstack == true && sb.length() > 0) {
    --- End diff --
    
    This change looks good to me. I gather that all the changes with the imports are just
clean-ups unrelated to this change?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message