trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From arvind-narain <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: [[ TRAFODION 1800 ]] Changes for...
Date Tue, 09 Feb 2016 17:53:08 GMT
Github user arvind-narain commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/302#discussion_r52345951
  
    --- Diff: install/installer/traf_add_sudoAccess ---
    @@ -42,4 +53,31 @@ if [[ $all_node_count -gt "1" ]]; then
     else 
        sudo cp $TRAF_USR /etc/sudoers.d
     fi
    - 
    +
    +}
    +
    +function copyFile {
    +
    +if [[ $all_node_count -gt "1" ]]; then
    +   $TRAF_PDCP $BACKUP_USER $HOME
    +   $TRAF_PDSH sudo cp $HOME/$BACKUP_USER /etc/sudoers.d/
    +   $TRAF_PDSH sudo rm -f $HOME/$BACKUP_USER
    +else
    +   sudo cp $BACKUP_USER /etc/sudoers.d
    +fi
    +
    +}
    +
    +
    +#Main
    +echo "***INFO: Creating $TRAF_USER sudo access file"
    +echo
    +
    +if [[ "$ENABLE_HA" == "Y" ]]; then
    --- End diff --
    
    ENABLE_HA gets set to true or false - should this check be for "true" ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message