trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From arvind-narain <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: [[ TRAFODION 1800 ]] Changes for...
Date Tue, 09 Feb 2016 18:05:27 GMT
Github user arvind-narain commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/302#discussion_r52347768
  
    --- Diff: install/installer/traf_config_check ---
    @@ -487,6 +487,18 @@ if [[ "$SUSE_LINUX" != "true" ]]; then
     fi
     }
     
    +function checkBackupUser {
    +
    +if [ -z $BACKUP_USER ]; then
    +   echo "***ERROR: BACKUP_USER variable not set in config file."
    +   echo "***WARNING: BACKUP_USER will be set to trafodion."
    +   sudo chmod 777 $TRAF_CONFIG
    +   sudo "export BACKUP_USER=\"trafodion\"" >> $TRAF_CONFIG
    +   sudo chmod 777 $TRAF_CONFIG
    +fi
    --- End diff --
    
    Should "source $TRAF_CONFIG" be done here after setting BACKUP_USER ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message