trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: run-time display methods for Atp...
Date Tue, 16 Feb 2016 17:09:28 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/323#discussion_r53042576
  
    --- Diff: core/sql/common/str.cpp ---
    @@ -1588,3 +1588,154 @@ Int32 str_convertToHexAscii(const char * src,               //
in
       return computedHexAsciiStrLen;
     }
     
    +void printBrief(char* dataPointer, Lng32 keyLen) 
    +{
    +  // We don't know what the data type is, but we do know how
    +  // long the field is. So we will guess the data type.
    +
    +  // The Generator transforms varchars to chars, so we don't
    --- End diff --
    
    This is only true for keys.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message